Messages in this thread Patch in this message | | | Subject | Re: [PATCHv2 1/1] block: IBM RamSan 70/80 driver fixes. | From | Joe Perches <> | Date | Tue, 19 Feb 2013 08:57:09 -0800 |
| |
On Tue, 2013-02-19 at 10:48 -0600, Philip J. Kelleher wrote: > From: Philip J Kelleher <pjk1939@linux.vnet.ibm.com> > > This patch include a few driver fixes for the IBM RamSan 70/80 driver.
trivial comments:
> diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/config.c linux-block/drivers/block/rsxx/config.c [] > @@ -161,6 +161,17 @@ irqreturn_t rsxx_isr(int irq, void *pdat > } > > /*----------------- Card Event Handler -------------------*/ > +static char *rsxx_card_state_to_str(unsigned int state)
static const char *
> +{ > + static char *state_strings[] = {
static const char * const state_strings[] = {
> + "Unknown", "Shutdown", "Starting", "Formatting", > + "Uninitialized", "Good", "Shutting Down", > + "Fault", "Read Only Fault", "dStroying" > + };
[]
> @@ -390,8 +391,13 @@ static int __issue_creg_rw(struct rsxx_c > if (st) > return st; > > + /* > + * This timeout is neccessary for unresponsive hardware. The additional
One "c" in necessary
> + * 20 seconds to used to guarantee that each cregs requests has time to > + * complete. > + */ > timeout = msecs_to_jiffies((CREG_TIMEOUT_MSEC * > - card->creg_ctrl.q_depth) + 20000); > + card->creg_ctrl.q_depth) + 20000);
The alignment was nicer before this change. Still using unnecessary parentheses.
| |