Messages in this thread | | | Date | Tue, 19 Feb 2013 16:54:44 +0200 | From | Nick Kossifidis <> | Subject | Re: [PATCH] NET: ath5k, check ath5k_eeprom_mode_from_channel retval |
| |
On Tue Feb 19 15:36:07 2013, Jiri Slaby wrote: > On 02/18/2013 01:47 AM, Nick Kossifidis wrote: >> int >> ath5k_eeprom_mode_from_channel(struct ieee80211_channel *channel) >> { >> switch (channel->hw_value) { >> case AR5K_MODE_11A: >> return AR5K_EEPROM_MODE_11A; >> case AR5K_MODE_11G: >> return AR5K_EEPROM_MODE_11G; >> case AR5K_MODE_11B: >> return AR5K_EEPROM_MODE_11B; >> default: >> return -1; >> } >> } >> >> I think we should just change that default to return 0 instead and add >> an ATH5K_WARN there. > > Something like the attached patch? It needs ah to be propagated to > eeprom. If you are fine with that, I'll send it as patch... > > thanks,
Just move the prototype on ath5k.h with the rest of them...
1523 /* EEPROM access functions */ 1524 int ath5k_eeprom_init(struct ath5k_hw *ah); 1525 void ath5k_eeprom_detach(struct ath5k_hw *ah);
| |