Messages in this thread Patch in this message | | | Date | Tue, 19 Feb 2013 12:36:44 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH] dma: timb_dma: Fix compiler warning |
| |
On 02/18/2013 08:59 PM, maxin.john@gmail.com wrote: > From: "Maxin B. John" <maxin.john@enea.com> > > Fix this compiler warning: > warning: 'td_remove' defined but not used [-Wunused-function] > > Signed-off-by: Maxin B. John <maxin.john@enea.com> > --- > drivers/dma/timb_dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c > index 952f823..f709279 100644 > --- a/drivers/dma/timb_dma.c > +++ b/drivers/dma/timb_dma.c > @@ -798,7 +798,7 @@ err_release_region: > > } > > -static int td_remove(struct platform_device *pdev) > +static int __exit td_remove(struct platform_device *pdev) > {
>
While this fixes the warning, it's the wrong fix. The correct fix is to remove the __exit_p. E.g. something like this:
--- a/drivers/dma/timb_dma.c +++ b/drivers/dma/timb_dma.c @@ -823,7 +823,7 @@ static struct platform_driver td_driver = { .owner = THIS_MODULE, }, .probe = td_probe, - .remove = __exit_p(td_remove), + .remove = td_remove, };
module_platform_driver(td_driver);
| |