Messages in this thread Patch in this message | | | Subject | kernel/signal.c - fix suboptimal printk usage | From | Valdis Kletnieks <> | Date | Mon, 18 Feb 2013 14:11:16 -0500 |
| |
Several printk's were missing KERN_INFO and KERN_CONT flags. In addition, a printk that was outside a #if/#endif should have been inside, which would result in stray blank line on non-x86 boxes.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
--- linux-next/kernel/signal.c.orig 2013-02-15 19:09:29.451843219 -0500 +++ linux-next/kernel/signal.c 2013-02-18 14:04:33.423065822 -0500 @@ -1157,11 +1157,11 @@ static int send_signal(int sig, struct s static void print_fatal_signal(int signr) { struct pt_regs *regs = signal_pt_regs(); - printk("%s/%d: potentially unexpected fatal signal %d.\n", + printk(KERN_INFO "%s/%d: potentially unexpected fatal signal %d.\n", current->comm, task_pid_nr(current), signr);
#if defined(__i386__) && !defined(__arch_um__) - printk("code at %08lx: ", regs->ip); + printk(KERN_INFO "code at %08lx: ", regs->ip); { int i; for (i = 0; i < 16; i++) { @@ -1169,11 +1169,11 @@ static void print_fatal_signal(int signr
if (get_user(insn, (unsigned char *)(regs->ip + i))) break; - printk("%02x ", insn); + printk(KERN_CONT "%02x ", insn); } } + printk(KERN_CONT "\n"); #endif - printk("\n"); preempt_disable(); show_regs(regs); preempt_enable(); [unhandled content-type:application/pgp-signature] | |