Messages in this thread | | | Date | Fri, 15 Feb 2013 16:23:26 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH v2] staging/comedi: Remove if(); statement without effect |
| |
On 2013-02-15 12:14, Peter Huewe wrote: > Smatch warns about: > staging/comedi/drivers/cb_pcidas64.c:3304 prep_ao_dma() warn: if(); > > So the check currently does nothing and can be removed, as indicated by > Ian. > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > --- > v1 was staging/comedi: Fix if(); by adding proper code > which was unfortunately wrong. > > drivers/staging/comedi/drivers/cb_pcidas64.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c > index d33fc32..9f3112c 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas64.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c > @@ -3301,7 +3301,6 @@ static int prep_ao_dma(struct comedi_device *dev, const struct comedi_cmd *cmd) > num_bytes = load_ao_dma_buffer(dev, cmd); > if (num_bytes == 0) > return -1; > - if (num_bytes >= DMA_BUFFER_SIZE) ; > load_ao_dma(dev, cmd); > > dma_start_sync(dev, 0); >
I suppose I'd better sign it off since you mentioned me. ;)
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
| |