lkml.org 
[lkml]   [2013]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 47/62] scsi/lpfc: convert to idr_alloc()
Acked-by: James Smart <james.smart@emulex.com>

-- james s


On 2/2/2013 8:20 PM, Tejun Heo wrote:
> Convert to the much saner new idr interface.
>
> Only compile tested.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: James Smart <james.smart@emulex.com>
> Cc: linux-scsi@vger.kernel.org
> ---
> This patch depends on an earlier idr changes and I think it would be
> best to route these together through -mm. Please holler if there's
> any objection. Thanks.
>
> drivers/scsi/lpfc/lpfc_init.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 89ad558..7de4ef14 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -3165,14 +3165,10 @@ destroy_port(struct lpfc_vport *vport)
> int
> lpfc_get_instance(void)
> {
> - int instance = 0;
> -
> - /* Assign an unused number */
> - if (!idr_pre_get(&lpfc_hba_index, GFP_KERNEL))
> - return -1;
> - if (idr_get_new(&lpfc_hba_index, NULL, &instance))
> - return -1;
> - return instance;
> + int ret;
> +
> + ret = idr_alloc(&lpfc_hba_index, NULL, 0, 0, GFP_KERNEL);
> + return ret < 0 ? -1 : ret;
> }
>
> /**



\
 
 \ /
  Last update: 2013-02-12 00:41    [W:0.380 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site