Messages in this thread | | | Date | Mon, 11 Feb 2013 17:14:48 +0530 | From | Vineet Gupta <> | Subject | Re: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script |
| |
On Monday 11 February 2013 04:59 PM, James Hogan wrote: > Hi Vineet, > > On 24/01/13 10:50, Vineet Gupta wrote: >> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig >> new file mode 100644 >> index 0000000..b0b09ae >> --- /dev/null >> +++ b/arch/arc/Kconfig >> @@ -0,0 +1,328 @@ >> +# >> +# Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. (www.synopsys.com) >> +# >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License version 2 as >> +# published by the Free Software Foundation. >> +# >> + >> +config ARC >> + def_bool y >> + select ARCH_NO_VIRT_TO_BUS > > I noticed this in linux-next. ARCH_NO_VIRT_TO_BUS was defined > generically in the past in linux-next but the patch seems to have gone. > Therefore with an arc defconfig I see CONFIG_VIRT_TO_BUS=y defined which > I'm guessing it shouldn't be.
Good catch ! I'll add a config ARCH_NO_VIRT_TO_BUS, but it would seem this is better done in arch/Kconfig and get rid of extraneous defs in arch/*/Kconfig. I can spin that patch, the only issue is merging logistics - our trees are not yet apt for such changes.
Thx, -Vineet
| |