lkml.org 
[lkml]   [2013]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V7] kbuild: create a rule to run the pre-processor on *.dts files
    On 02/01/2013 03:01 AM, Srinivas KANDAGATLA wrote:
    > Hi Stephen,
    > Not sure if you have already noticed this but,
    > I did try this patch on my 3.8, and it looks like the intermediate dts
    > file replaces all instances of linux with 1 because of predefined macros
    > in gcc.
    > As a result
    > linux,stdout-path = "/soc/stm-asc2";
    > is changed to.
    > 1,stdout-path = "/soc/stm-asc2";
    >
    > On my version of compiler(gcc version 4.6.3) I have
    >
    > armv7-linux-gcc -E -dM - < /dev/null | grep -v _
    > #define unix 1
    > #define linux 1
    >
    > Which might be true with most compiler versions aswell.
    > As we are using linux as prefix for some device tree properties it makes
    > sense to undef the linux gcc define.
    > Adding -Ulinux to cmd_dtc_cpp should fix it.
    >
    > -cmd_dtc_cpp = $(CPP) $(cpp_flags) -D__DTS__ -x assembler-with-cpp -o
    > $(dtc-tmp) $< ; \
    > +cmd_dtc_cpp = $(CPP) $(cpp_flags) -D__DTS__ -Ulinux -x
    > assembler-with-cpp -o $(dtc-tmp) $< ; \
    > $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) $(dtc-tmp)

    That's a hackish solution that seems fragile as well. Is there no way to
    turn off all built-in defines?

    Rob


    \
     
     \ /
      Last update: 2013-02-01 18:21    [W:3.274 / U:1.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site