lkml.org 
[lkml]   [2013]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/10] TTY: switch tty_schedule_flip
On 02/01/2013 01:37 PM, Peter Hurley wrote:
> On Thu, 2013-01-03 at 15:53 +0100, Jiri Slaby wrote:
>> Now, we start converting tty buffer functions to actually use
>> tty_port. This will allow us to get rid of the need of tty in many
>> call sites. Only tty_port will needed and hence no more
>> tty_port_tty_get in those paths.
>>
>> This is the last one: tty_schedule_flip
>
> [snip]
>
>> diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
>> index 5aace4d..a9af1b9a 100644
>> --- a/drivers/tty/vt/keyboard.c
>> +++ b/drivers/tty/vt/keyboard.c
>> @@ -307,26 +307,17 @@ int kbd_rate(struct kbd_repeat *rep)
>> */
>> static void put_queue(struct vc_data *vc, int ch)
>> {
>> - struct tty_struct *tty = vc->port.tty;
>> -
>> tty_insert_flip_char(&vc->port, ch, 0);
>> - if (tty) {
>> - tty_schedule_flip(tty);
>> - }
>> + tty_schedule_flip(&vc->port);
>> }
>>
>> static void puts_queue(struct vc_data *vc, char *cp)
>> {
>> - struct tty_struct *tty = vc->port.tty;
>> -
>> - if (!tty)
>> - return;
>> -
>> while (*cp) {
>> tty_insert_flip_char(&vc->port, *cp, 0);
>> cp++;
>> }
>> - tty_schedule_flip(tty);
>> + tty_schedule_flip(&vc->port);
>> }
>
> Umm. So even though the vt driver knows the tty has been shutdown,
> keystrokes will still be buffered? And then fed to whichever tty happens
> to next get installed on the same port?

Unless I completely missed something, they should be flushed. If that's
not the case, that's a bug. I will check next week.

thanks,
--
js
suse labs


\
 
 \ /
  Last update: 2013-02-01 16:44    [W:0.172 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site