Messages in this thread | | | Date | Mon, 9 Dec 2013 16:17:32 +0000 | From | Christoph Lameter <> | Subject | Re: [PATCH v2 2/7] mm/migrate: correct failure handling if !hugepage_migration_support() |
| |
On Mon, 9 Dec 2013, Joonsoo Kim wrote:
> We should remove the page from the list if we fail without ENOSYS, > since migrate_pages() consider error cases except -ENOMEM and -EAGAIN > as permanent failure and it assumes that the page would be removed from > the list. Without this patch, we could overcount number of failure.
Ok what does the patch do about this? I dont see any modifications. Remove this part of the description?
> In addition, we should put back the new hugepage if > !hugepage_migration_support(). If not, we would leak hugepage memory.
Ok looks like that is fixed by this patch.
Acked-by: Christoph Lameter <cl@linux.com>
| |