lkml.org 
[lkml]   [2013]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 1/6] net: mv643xx_eth: properly start/stop phy device
    Date
    When using phydev, it should be phy_start/phy_stop'ed properly. This
    driver doesn't do that, so add the corresponding calls to port_start/
    stop respectively.

    Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
    Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    ---
    Cc: David Miller <davem@davemloft.net>
    Cc: Florian Fainelli <f.fainelli@gmail.com>
    Cc: Mugunthan V N <mugunthanvnm@ti.com>
    Cc: netdev@vger.kernel.org
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-kernel@vger.kernel.org
    ---
    drivers/net/ethernet/marvell/mv643xx_eth.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
    index 61088a6..3aa706f 100644
    --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
    +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
    @@ -2098,6 +2098,7 @@ static void port_start(struct mv643xx_eth_private *mp)
    mv643xx_eth_get_settings(mp->dev, &cmd);
    phy_reset(mp);
    mv643xx_eth_set_settings(mp->dev, &cmd);
    + phy_start(mp->phy);
    }

    /*
    @@ -2293,7 +2294,8 @@ static int mv643xx_eth_stop(struct net_device *dev)
    del_timer_sync(&mp->rx_oom);

    netif_carrier_off(dev);
    -
    + if (mp->phy)
    + phy_stop(mp->phy);
    free_irq(dev->irq, dev);

    port_reset(mp);
    --
    1.8.4.rc3


    \
     
     \ /
      Last update: 2013-12-08 16:01    [W:3.306 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site