lkml.org 
[lkml]   [2013]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v3 00/19] slight optimization of addr compare for net modules
From
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Mon, 30 Dec 2013 15:40:25 +0800

> This is the second patchset for slight optimization of address compare,
> mainly for net tree, just following the Joe's opinion, it will help review
> the code for maintainers and supports.
>
> v2: Change some style for patch 2.
> According Eric's suggestion, use the ether_addr_equal_64bits to instead
> of ether_addr_equal for patch 19.
> In fact, there are a lot of places which could use ether_addr_equal_64bits
> to instead of ether_addr_equal, but not this time, thanks for Joe's
> opinion.
>
> v3: Change some style for patch 11/19:
> (net: packetengines: slight optimization of addr compare).
> Joe pointed out that is_broadcast_ether_addr(addr) would be appropriate here,
> but this should be left alone and not in this patch, so fix it later.
>
> In the patch (net: caif: slight optimization of addr compare), the operand for
> memcmp is not mac address, so it is unsuitable to use the ether_addr_equal
> to compare a non mac address, so remove the patch from the series.

Series applied, thanks.


\
 
 \ /
  Last update: 2013-12-31 23:21    [W:0.097 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site