lkml.org 
[lkml]   [2013]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Xen-devel] [PATCH v11 09/12] xen/pvh: Piggyback on PVHVM XenBus and event channels for PVH.
    > > --- a/drivers/xen/xenbus/xenbus_client.c
    > > +++ b/drivers/xen/xenbus/xenbus_client.c
    > > @@ -45,6 +45,7 @@
    > > #include <xen/grant_table.h>
    > > #include <xen/xenbus.h>
    > > #include <xen/xen.h>
    > > +#include <xen/features.h>
    > >
    > > #include "xenbus_probe.h"
    > >
    > > @@ -743,7 +744,7 @@ static const struct xenbus_ring_ops ring_ops_hvm = {
    > >
    > > void __init xenbus_ring_ops_init(void)
    > > {
    > > - if (xen_pv_domain())
    > > + if (xen_pv_domain() && !xen_feature(XENFEAT_auto_translated_physmap))
    >
    > Can we just change this test to
    >
    > if (!xen_feature(XENFEAT_auto_translated_physmap))
    >
    > ?

    No. If we do then the HVM domains (which are also !auto-xlat)
    will end up using the PV version of ring_ops.
    >
    >
    > > ring_ops = &ring_ops_pv;
    > > else
    > > ring_ops = &ring_ops_hvm;
    > > --
    > > 1.8.3.1
    > >
    > >
    > > _______________________________________________
    > > Xen-devel mailing list
    > > Xen-devel@lists.xen.org
    > > http://lists.xen.org/xen-devel
    > >


    \
     
     \ /
      Last update: 2013-12-31 21:15    [W:4.048 / U:0.860 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site