Messages in this thread | | | Date | Tue, 31 Dec 2013 10:45:46 -0800 | Subject | Re: [PATCH][tentative] PCI / ACPI: Rework PCI host bridge removal to avoid sysfs warnings | From | Yinghai Lu <> |
| |
On Mon, Dec 30, 2013 at 5:15 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Monday, December 30, 2013 01:51:28 PM Rafael J. Wysocki wrote: >> > We have patches that need to stop ioapic and iommu between >> > pci_stop_root_bus and pci_remove_root_bus. > > BTW, what *exactly* do they need to be stopped between? After these two patches:
need to stop regular pci drivers before stop "driver" for ioapic/dmar.
> >> > Please check if the problem still happen after >> > >> > http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/patch/?id=c4a0a5d964e90b93eb4101c3927b788e083e530f >> > >> > http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/patch/?id=e3b439e1d315aff59c1b4f0fc43c5cd2d82b4138 > > pci_stop_root_bus() is just a walk over devices on the root bus stopping > them and pci_remove_root_bus() starts with the removal of those devices. > > Surely, those two list walks can be combined into one?
maybe ok, but we have to problem to make sure stop pci drivers before "driver" for ioapic/dmar.
also stop all first and remove all make it much cleaner.
and add path is two steps too. Add them all, and then attach driver for all.
Thanks
Yinghai
| |