lkml.org 
[lkml]   [2013]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] pid: get pid_t ppid of task in init_pid_ns
On 12/23, Richard Guy Briggs wrote:
>
> +static inline pid_t task_ppid_nr_ns(struct task_struct *tsk, struct pid_namespace *ns)
> +{
> + pid_t pid;
> +
> + rcu_read_lock();
> + pid = pid_alive(tsk) ?
> + task_pid_nr_ns(rcu_dereference(tsk->real_parent), ns) : 0;
> + rcu_read_unlock();
> +
> + return pid;
> +}

I do not really mind, but perhaps

pid_t pid = 0;

rcu_read_lock();
if (pid_alive(task))
pid = task_pid_nr_ns(rcu_dereference(tsk->real_parent);
rcu_read_unlock();

return pid;

looks a bit cleaner.

> +static inline pid_t task_ppid_nr(struct task_struct *tsk)
> +{
> + pid_t pid;
> +
> + rcu_read_lock();
> + pid = pid_alive(tsk) ?
> + task_pid_nr(rcu_dereference(tsk->real_parent)) : 0;
> + rcu_read_unlock();
> +
> + return pid;
> +}

It could simply do

return task_ppid_nr_ns(tsk, init_pid_ns);

but again, I won't argue.

Oleg.



\
 
 \ /
  Last update: 2013-12-30 19:01    [W:0.154 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site