lkml.org 
[lkml]   [2013]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] slub: Fix calculation of cpu slabs
From
On Sat, Oct 5, 2013 at 10:48 AM, Wanpeng Li <liwanp@linux.vnet.ibm.com> wrote:
> On Tue, Sep 10, 2013 at 11:43:37AM +0800, Li Zefan wrote:
>> /sys/kernel/slab/:t-0000048 # cat cpu_slabs
>> 231 N0=16 N1=215
>> /sys/kernel/slab/:t-0000048 # cat slabs
>> 145 N0=36 N1=109
>>
>>See, the number of slabs is smaller than that of cpu slabs.
>>
>>The bug was introduced by commit 49e2258586b423684f03c278149ab46d8f8b6700
>>("slub: per cpu cache for partial pages").
>>
>>We should use page->pages instead of page->pobjects when calculating
>>the number of cpu partial slabs. This also fixes the mapping of slabs
>>and nodes.
>>
>>As there's no variable storing the number of total/active objects in
>>cpu partial slabs, and we don't have user interfaces requiring those
>>statistics, I just add WARN_ON for those cases.
>>
>>Cc: <stable@vger.kernel.org> # 3.2+
>>Signed-off-by: Li Zefan <lizefan@huawei.com>
>
> Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Applied and sorry for the slow response!


\
 
 \ /
  Last update: 2013-12-29 13:21    [W:0.236 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site