Messages in this thread | | | From | Michal Malý <> | Subject | Re: [RFC v3] Add ff-memless-next | Date | Tue, 24 Dec 2013 03:11:57 +0100 |
| |
On Monday 23 of December 2013 16:21:48 you wrote: > On Mon, 2013-12-23 at 23:46 +0100, Michal Malý wrote: > > One case where uncombinable effects were mishandled was corrected. Rest of > > the changes are just coding style fixes. > > trivia: > > diff --git a/drivers/input/ff-memless-next.c > > b/drivers/input/ff-memless-next.c > [] > > > +static __always_inline s32 mlnx_calculate_x_force(const s32 level, > > + const u16 direction) > > __always_inline is almost never warranted. > gcc generally does the right thing. I did some reading about __always_inline vs. plain inline and I ran into some contradictory information about what is considered broken. Thanks for letting me know...
Is there anything else that needs some reviewing? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |