Messages in this thread | | | Date | Mon, 23 Dec 2013 22:19:45 +0100 | From | Florian Vaussard <> | Subject | Re: [PATCH 4/7] iommu/omap: Allow enable/disable even without pdata |
| |
Hi Suman,
On 12/23/2013 08:05 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> When booting with a devietree, no platform data is provided. Do not >> prematurely >> exit iommu_enable() and iommu_disable() in such a case. > > Platform data may still be needed if we were to go with the pdata quirks > approach for handling resets. You may need to revise the patch > description then, but the change itself may be ok if supporting only DT > devices. >
Indeed, this should be mentioned in the commit message. I would go for a pdata-quirk until we have a proper reset-controller.
Regards,
Florian
| |