Messages in this thread | | | Date | Mon, 23 Dec 2013 22:50:22 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH v3 1/2] regulator: anatop-regulator: Fix the error handling on probe |
| |
On Mon, Dec 23, 2013 at 12:44:40PM -0200, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Currently when of_get_parent() or syscon_node_to_regmap() fail > 'kfree(sreg->name)' is not called, which is incorrect. > > Fix this by jumping to 'anatop_probe_end' instead. > > While at it, make 'anatop_probe_end' to be executed only on the error path, so > that the code can be a bit easier to follow. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
| |