Messages in this thread | | | Date | Mon, 23 Dec 2013 07:32:40 -0500 | From | Prarit Bhargava <> | Subject | Re: [PATCH] x86: Add check for number of available vectors before CPU down [v3] |
| |
On 12/23/2013 02:12 AM, Chen, Gong wrote: > On Fri, Dec 20, 2013 at 10:50:09AM -0500, Prarit Bhargava wrote: >> +int check_vectors(void) >> +{ >> + int irq, cpu; >> + unsigned int vector, this_count, count; >> + struct irq_desc *desc; >> + struct irq_data *data; >> + struct cpumask *affinity; >> + >> + this_count = 0; >> + for (vector = FIRST_EXTERNAL_VECTOR; vector < NR_VECTORS; vector++) { >> + irq = __this_cpu_read(vector_irq[vector]); >> + if (irq >= 0) { >> + desc = irq_to_desc(irq); >> + data = irq_desc_get_irq_data(desc); >> + affinity = data->affinity; >> + if (irq_has_action(irq) || !irqd_is_per_cpu(data) || > This line looks weird. Why counter will be increased once the irq has > action? Do you mean > > if (irq_has_action(irq) && !irqd_is_per_cpu(data) && > !cpumask_subset(affinity, cpu_online_mask)) > >
Yes, you're absolutely right. I mixed up the and and or's on this line of code. I will send out a patch against tip shortly.
P.
| |