lkml.org 
[lkml]   [2013]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe : Re: Re: Re : Re: [PATCH] Squashfs: add asynchronous read support
From
Date


> read_pages
> for(page_idx ...) {
> if (!add_to_page_cache_lru)) { <-- 1)
> mapping->a_ops->readpage(filp, page)
> squashfs_readpage
> for (i ...) { 2) Here, 31 pages are inserted into page cache
> grab_cahe_page_nowait <------/
> add_to_page_cache_lru
> }
> }
> /*
> * 1) will be failed with EEXIST by 2) so every pages other than first page
> * in list would be freed
> */
> page_cache_release(page)
> }
>
> If you see ReadAhead works, it is just by luck as I told you.
> Please simulate it with 64K dd.
You right, This luck happened frequently with 128k dd or my test.

> I understand it but your patch doesn't make it.
>
I think my patch can make it if readahead works normally or luckily.

Thanks a lot!
Chanho,



\
 
 \ /
  Last update: 2013-12-23 04:21    [W:0.056 / U:4.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site