lkml.org 
[lkml]   [2013]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] tracing: A few trace event triggers fixes
On Sat, 21 Dec 2013 16:43:59 -0600
Tom Zanussi <tom.zanussi@linux.intel.com> wrote:

> This patchset fixes a few sparse warnings and build problems seen
> under certain configurations, as uncovered by the kbuild test robot.
>
> Applies to linux-trace.git ftrace/core.
>
> The following changes since commit 611e9015501ab9597d6a43253813d4efd90936de:
>
> tracing: Add documentation for trace event triggers (2013-12-20 23:24:20 -0500)

Thanks Tom, but I'm also in the process of fixing these up ;-)

>
> are available in the git repository at:
>
> git://git.yoctoproject.org/linux-yocto-contrib.git tzanussi/event-triggers-ftrace-core-kbuild-robot-fixes
> http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-contrib/log/?h=tzanussi/event-triggers-ftrace-core-kbuild-robot-fixes
>
> Tom Zanussi (3):
> tracing: Move tracing_alloc_snapshot() declaration to tracing.h

Heh, my fix was just to return -1, but I'll use your fix instead.

> tracing: Add and use event_trigger_lseek()

I've actually changed added a generic tracing_lseek() for all to use.

I'll use my patch instead.

> tracing: Add rcu annotation for event_trigger_data.filter

Running sparse with this change required more than just the added
__rcu that you added (as I did too). I'll fix this up and start testing
as well. I'll post the two patches I did just for you to give an ack
on.

Thanks!

-- Steve

>
> include/linux/kernel.h | 2 --
> kernel/trace/trace.h | 3 ++-
> kernel/trace/trace_events_trigger.c | 15 ++++++++++++++-
> 3 files changed, 16 insertions(+), 4 deletions(-)
>



\
 
 \ /
  Last update: 2013-12-22 00:21    [W:1.062 / U:1.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site