lkml.org 
[lkml]   [2013]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: checkpatch.pl error might be false positive
From
Date
On Fri, 2013-12-20 at 01:16 -0800, Josh Triplett wrote:
> Duplicating the regex seems awful. Could you put it in a variable?

awful is a strong word and I don't have any
issue with the duplication. Using a variable
is just as confusing as any duplication.

Using a separate test and message for the GPL
vs the FSF bits would likely be better anyway.

You're the original FSF address patch submitter,
fix it as you think appropriate.



\
 
 \ /
  Last update: 2013-12-20 10:41    [W:0.065 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site