Messages in this thread | | | Subject | Re: checkpatch.pl error might be false positive | From | Joe Perches <> | Date | Fri, 20 Dec 2013 01:23:52 -0800 |
| |
On Fri, 2013-12-20 at 01:16 -0800, Josh Triplett wrote: > Duplicating the regex seems awful. Could you put it in a variable?
awful is a strong word and I don't have any issue with the duplication. Using a variable is just as confusing as any duplication.
Using a separate test and message for the GPL vs the FSF bits would likely be better anyway.
You're the original FSF address patch submitter, fix it as you think appropriate.
| |