Messages in this thread | | | Date | Fri, 20 Dec 2013 09:01:59 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCHv2 1/3] silicom: fix whitespace issues in bypass.c |
| |
On Fri, Dec 20, 2013 at 08:36:48PM +0530, Gokulnath A wrote: > Hello Michael, > > On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler > <michael.hoefler@studium.uni-erlangen.de> wrote: > > This patch addresses several problems in bypass.c found by checkpatch. > > Furthermore it removes/adds some empty lines to make the code more readable. > > > > The following problems are fixed: > > - line over 80 characters > > - space after logical operator ! > > - spaces instead of tabs > > - missing empty line after local declarations > > - empty line after { > > > > Please do one thing per patch, As Greg suggested for me in previous mail > conversations. Here you could have at least 3 or 4 patches. > For example, first patch would be a fix for line over 80 characters, > followed by the other problems as mentioned above by you.
Nah, all of these are affecting the same macros, so it's ok, I'll take it as-is.
thanks,
greg k-h
| |