Messages in this thread Patch in this message | | | Date | Mon, 02 Dec 2013 21:16:08 +0800 | From | Younger Liu <> | Subject | [PATCH 0/2] f2fs: remove debufs dir if debugfs_create_file() failed |
| |
From: Younger Liu <liuyiyang@hisense.com>
When debugfs_create_file() failed in f2fs_create_root_stats(), debugfs_root should be removed.
Signed-off-by: Younger Liu <liuyiyang@hisense.com> Cc: Younger Liu <younger.liucn@gmail.com> Cc: Jaegeuk Kim <jaegeuk.kim@samsung.com> --- fs/f2fs/debug.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index a84b0a8..d27b689 100644 --- a/fs/f2fs/debug.c +++ b/fs/f2fs/debug.c @@ -340,10 +340,24 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi) void __init f2fs_create_root_stats(void) { + struct dentry *file; + debugfs_root = debugfs_create_dir("f2fs", NULL); - if (debugfs_root) - debugfs_create_file("status", S_IRUGO, debugfs_root, - NULL, &stat_fops); + if (!debugfs_root) + goto bail; + + file = debugfs_create_file("status", S_IRUGO, + debugfs_root, NULL, &stat_fops); + if (!file) + goto free_debugfs_dir; + + return; + +free_debugfs_dir: + debugfs_remove(debugfs_root); + +bail: + return; } void f2fs_destroy_root_stats(void) -- 1.7.9.5
| |