lkml.org 
[lkml]   [2013]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/11] serial: support for 16550 serial ports on LP-8x4x
    On Mon, Dec 02, 2013 at 03:39:26PM +0400, Sergei Ianovich wrote:
    > On Mon, 2013-12-02 at 11:30 +0000, Russell King - ARM Linux wrote:
    > > On Sun, Dec 01, 2013 at 10:26:18AM +0400, Sergei Ianovich wrote:
    > > > +static struct platform_device lp8x4x_device = {
    > > > + .name = "serial8250",
    > > > + .id = PLAT8250_DEV_ACCENT,
    > >
    > > You should not re-use the enum value here. The enum is designed as a
    > > method to provide the platform devices with a unique id, not as a means
    > > to identify the manufacturer or anything else like that.
    >
    > Should I add a new enum?

    Add a new enum.


    \
     
     \ /
      Last update: 2013-12-02 13:41    [W:5.122 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site