lkml.org 
[lkml]   [2013]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 011/208] usbnet: fix status interrupt urb handling
    Date
    3.11.10.2 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Felix Fietkau <nbd@openwrt.org>

    commit 52f48d0d9aaa621ffa5e08d79da99a3f8c93b848 upstream.

    Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf
    "sierra_net: keep status interrupt URB active", sierra_net triggers
    status interrupt polling before the net_device is opened (in order to
    properly receive the sync message response).

    To be able to receive further interrupts, the interrupt urb needs to be
    re-submitted, so this patch removes the bogus check for netif_running().

    Signed-off-by: Felix Fietkau <nbd@openwrt.org>
    Tested-by: Dan Williams <dcbw@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/usb/usbnet.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
    index 06ee82f..28f16ed 100644
    --- a/drivers/net/usb/usbnet.c
    +++ b/drivers/net/usb/usbnet.c
    @@ -206,9 +206,6 @@ static void intr_complete (struct urb *urb)
    break;
    }

    - if (!netif_running (dev->net))
    - return;
    -
    status = usb_submit_urb (urb, GFP_ATOMIC);
    if (status != 0)
    netif_err(dev, timer, dev->net,
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-12-20 10:01    [W:4.084 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site