lkml.org 
[lkml]   [2013]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86 idle: repair large-server 50-watt idle-power regression
On 12/19/2013 04:22 AM, Ingo Molnar wrote:
>> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
>> index 92d1206..f80b700 100644
>> --- a/drivers/idle/intel_idle.c
>> +++ b/drivers/idle/intel_idle.c
>> @@ -377,6 +377,9 @@ static int intel_idle(struct cpuidle_device *dev,
>>
>> if (!current_set_polling_and_test()) {
>>
>> + if (this_cpu_has(X86_FEATURE_CLFLUSH_MONITOR))
>> + clflush((void *)&current_thread_info()->flags);
>> +
>> __monitor((void *)&current_thread_info()->flags, 0, 0);
>
> I don't think either of these casts to '(void *)' is needed, both the
> clflush() and __monitor() will take pointers.

__monitor() currently doesn't, which is idiotic.

-hpa



\
 
 \ /
  Last update: 2013-12-20 05:01    [W:0.246 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site