Messages in this thread | | | Date | Thu, 19 Dec 2013 19:21:36 -0500 (EST) | Subject | Re: [PATCH v2] net: mvmdio: fix interrupt timeout handling | From | David Miller <> |
| |
From: Leigh Brown <leigh@solinno.co.uk> Date: Thu, 19 Dec 2013 13:09:48 +0000
> This version corrects the whitespace issue. > > orion_mdio_wait_ready uses wait_event_timeout to wait for the > SMI interrupt to fire. wait_event_timeout waits for between > "timeout - 1" and "timeout" jiffies. In this case a 1ms timeout > when HZ is 1000 results in a wait of 0 to 1 jiffies, causing > premature timeouts. > > This fix ensures a minimum timeout of 2 jiffies, ensuring > wait_event_timeout will always wait at least 1 jiffie. > > Issue reported by Nicolas Schichan. > > Tested-by: Nicolas Schichan <nschichan@freebox.fr> > Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
Applied, and queued up for -stable.
I wonder how many other wait_event_timeout() users potentially have this problem.
| |