lkml.org 
[lkml]   [2013]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7] drivers: usb: Include appropriate header file in pci-quirks.c
    On Thu, 19 Dec 2013, Rashika Kheria wrote:

    > Include header file include/linux/usb/hcd.h in host/pci-quirks.c because
    > function usb_hcd_amd_remote_wakeup_quirk() has its prototype declaration
    > in include/linux/usb/hcd.h.
    >
    > This eliminates the following warning in host/pci-quirks.c:
    > drivers/usb/host/pci-quirks.c:253:5: warning: no previous prototype for ‘usb_hcd_amd_remote_wakeup_quirk’ [-Wmissing-prototypes]

    Since when does the compiler complain about functions with no
    prototype?

    In any case, I think it would make more sense to move the prototype
    declaration into drivers/usb/host/pci-quirks.h, and have
    drivers/usb/core/hcd-pci.c include that file. After all, it's
    perfectly reasonable for hcd-pci to want to know about the quirks of
    various PCI-based controllers, but it's not reasonable for pci-quirks.c
    to need to know about the details of HCDs.

    Alan Stern

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-12-19 17:21    [W:4.400 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site