Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3) | Date | Thu, 19 Dec 2013 16:20:46 +0900 |
| |
On Wed, 18 Dec 2013 14:47:15 -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 18, 2013 at 11:37:49PM +0900, Namhyung Kim escreveu: >> 2013-12-18 (수), 10:46 +0100, Ingo Molnar: >> > * Namhyung Kim <namhyung@kernel.org> wrote: > >> > > I changed the option as a separate --cumulate and added a new >> > > "Total" column (and renamed the default "Overhead" column into >> > > "Self"). The output will be sorted by total (cumulative) overhead >> > > for now. The reason I changed to the --cumulate is that I still >> > > think it's much different from other --callchain options and I >> > > plan to add support for showing (remaining) callchains to >> > > cumulative entries too. The --callchain option will take care of >> > > it even with --cumulate option. > >> > So I still think this is a fantastic feature, and while this variant >> > of the user interface is an improvement over the previous version, we >> > are not there yet ;-) >> >> Right. But I want to finish the core part of this patchset first. And >> then I will work on the UI part since it'll be a quite large work by >> itself, I guess. > > I got the first few ones, that are not really related to this, to reduce > the patchkit size, will go thru the others next.
Right. I missed to mention that they're independent cleanups, thanks.
> >> > So the natural way to get this would something like: >> > >> > perf report --total >> > >> > Or, if '--total' does not feel good, maybe we should change 'Total' to >> > 'Siblings' or 'Children', and propagate that naming through the UI: >> >> Childrend looks better to me. > > --children, ack
Okay.
Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |