lkml.org 
[lkml]   [2013]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 204/208] HID: kye: Fix missing break in kye_report_fixup()
    Date
    3.11.10.2 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ben Hutchings <ben@decadent.org.uk>

    commit 0a5f99cfff2297f6c350b7f54878cbbf1b1253d5 upstream.

    The change to support Genius Manticore Keyboard also changed behaviour
    for Genius Gx Imperator Keyboard, as there is no break between the
    cases. This is presumably a mistake.

    Reported by Coverity as CID 1134029.

    Fixes: 4a2c94c9b6c0 ('HID: kye: Add report fixup for Genius Manticore Keyboard')
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/hid/hid-kye.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c
    index 35a4f9c..d645caa 100644
    --- a/drivers/hid/hid-kye.c
    +++ b/drivers/hid/hid-kye.c
    @@ -341,6 +341,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc,
    case USB_DEVICE_ID_GENIUS_GX_IMPERATOR:
    rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83,
    "Genius Gx Imperator Keyboard");
    + break;
    case USB_DEVICE_ID_GENIUS_MANTICORE:
    rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104,
    "Genius Manticore Keyboard");
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-12-19 13:41    [W:4.095 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site