Messages in this thread | | | Subject | RE: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c | Date | Thu, 19 Dec 2013 17:33:09 -0000 | From | "David Laight" <> |
| |
> > These warning are non-default GCC warnings. These can be seen either > > by adding W=1 while running make (i.e. make W=1) or adding > > -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile. > > By default, we don't care about 'W=1' warnings, as no one sees them, and > they don't matter.
-Wmissing-prototypes really ought to be defined.
Some of the other warning are a little more pedantic, the most annoying is -Wsign-compare. OTOH a lot of code out there is clean enough to build without any warnings and with a moderate amount of pedantry from the compiler.
OTOH just including extra headers isn't ideal - it can considerably slow down the compilation time. There are many subsystems that don't really separate their internal headers from their external ones.
David
| |