Messages in this thread | | | Date | Thu, 19 Dec 2013 11:14:20 +0800 | From | Freddy Xin <> | Subject | Re: [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving NET_IP_ALIGN bytes for an SKB. |
| |
On 2013年12月16日 18:09, David Laight wrote: >> I was thinking of something like: skb = netdev_alloc_skb(dev, length >> + dev->skb_align, gfp); if (NET_IP_ALIGN && skb && !(ev->driver_flags >> & FLAG_HW_IPALIGN)) skb_reserve(skb, NET_IP_ALIGN); It might even be >> reasonable to remove the length adjustment - provided that all the >> later code uses the skb length. David
Thanks for your advice. In the way you advised, does the dev->skb_align equal to NET_IP_ALIGN in the case that HW doesn't supoort IP alignment? In other words, dev->skb_align should be initialized to NET_IP_ALIGN in USBNET, and I can change its value to 0 in AX88179_178A driver, right?
Freddy
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |