lkml.org 
[lkml]   [2013]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] perf/x86: add RAPL PP1 energy counter support

Nice patch!

I noticed a couple of small details:

* Stephane Eranian <eranian@google.com> wrote:

> Add support for the RAPL energy counter PP1.
>
> On client processors, it usually correspondss to the

s/correspondss
/corresponds

> energy consumption of the builtin graphic card.
>
> New event:
> - name: power/energy-gfx/
> - code: event=0x4
> - unit: 2^-32 Joules
>
> On processors without graphics, this should count 0.
> The patch only enables this event on client processors.

> EVENT_ATTR_STR(energy-cores, rapl_cores, "event=0x01");
> EVENT_ATTR_STR(energy-pkg , rapl_pkg, "event=0x02");
> EVENT_ATTR_STR(energy-ram , rapl_ram, "event=0x03");
> +EVENT_ATTR_STR(energy-gfx, rapl_gfx, "event=0x04");

> EVENT_ATTR_STR(energy-cores.unit, rapl_cores_unit, "Joules");
> EVENT_ATTR_STR(energy-pkg.unit , rapl_pkg_unit, "Joules");
> EVENT_ATTR_STR(energy-ram.unit , rapl_ram_unit, "Joules");
> +EVENT_ATTR_STR(energy-gfx.unit , rapl_gfx_unit, "Joules");

Nit: I think these fields have all similar lengths so they should be
vertically aligned, something like:

EVENT_ATTR_STR(energy-cores, rapl_cores, "event=0x01");
EVENT_ATTR_STR(energy-pkg , rapl_pkg , "event=0x02");
EVENT_ATTR_STR(energy-ram , rapl_ram , "event=0x03");
EVENT_ATTR_STR(energy-gfx , rapl_gfx , "event=0x04");

EVENT_ATTR_STR(energy-cores.unit, rapl_cores_unit, "Joules");
EVENT_ATTR_STR(energy-pkg.unit , rapl_pkg_unit , "Joules");
EVENT_ATTR_STR(energy-ram.unit , rapl_ram_unit , "Joules");
EVENT_ATTR_STR(energy-gfx.unit , rapl_gfx_unit , "Joules");

Also, instead of 'gfx', shouldn't it be 'gpu' throughout the patch?

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-12-17 12:01    [W:0.261 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site