lkml.org 
[lkml]   [2013]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support
    On Mon, Dec 16, 2013 at 03:20:01PM -0600, Felipe Balbi wrote:
    > On Fri, Dec 13, 2013 at 11:51:19AM -0500, Matt Porter wrote:
    > > If a generic phy is present, call phy_init()/phy_exit(). This supports
    > > generic phys that must be soft reset before power on.
    > >
    > > Signed-off-by: Matt Porter <mporter@linaro.org>
    > > Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
    > > ---
    > > drivers/usb/gadget/s3c-hsotg.c | 5 +++++
    > > 1 file changed, 5 insertions(+)
    > >
    > > diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
    > > index 7c5d8bd..e9683c2 100644
    > > --- a/drivers/usb/gadget/s3c-hsotg.c
    > > +++ b/drivers/usb/gadget/s3c-hsotg.c
    > > @@ -3621,6 +3621,9 @@ static int s3c_hsotg_probe(struct platform_device *pdev)
    > > goto err_supplies;
    > > }
    > >
    > > + if (hsotg->phy)
    > > + phy_init(hsotg->phy);
    >
    > doesn't build. you need to include <linux/phy/phy.h>

    It depends on https://lkml.org/lkml/2013/12/5/172 which I noted in the
    cover letter. At this point, I don't know if Kamil's whole series will
    make it to 3.14 so that patch may have to be taken separately. He has a
    trivial update to make on the binding example is all for this patch.

    I was wondering today if we might just want to separate that out now. I
    originally had a similar patch in my series but his was posted first so
    I rebased on that.

    -Matt


    \
     
     \ /
      Last update: 2013-12-16 23:01    [W:2.161 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site