Messages in this thread | | | Date | Mon, 16 Dec 2013 17:05:27 +0100 | Subject | Re: [PATCH] mfd: (max8997) Handle the potential error for mfd_add_devices | From | Richard Weinberger <> |
| |
On Mon, Dec 16, 2013 at 4:51 PM, Laszlo Papp <lpapp@kde.org> wrote: >>> > The $SUBJECT line is wrong. To see how a subsystem usually formats >>> > theirs you must do something like `git log --oneline -- <subsystem>`. >>> > And duplicate the format. >>> > >>> > Commit message? >> >> These comments are still relevant, please re-post your patch with the >> points rectified. > > I really do not understand how they relevant. "Commit message?" -> > What about it? It has a pretty clear commit message. Are you now just > picking nits about "foo:" vs "(foo)" in the short line?
The commit message needs to have subject and a body. A good message body explains what the current situation is, why it is broken/has problems and how this patch fixes that.
-- Thanks, //richard
| |