lkml.org 
[lkml]   [2013]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()
From
Date
On Fri, 2013-12-13 at 16:06 -0700, Bjorn Helgaas wrote:

> I should have thought longer before hitting send. I think it's worthwhile
> to use the same helper in aer_hest_parse_aff(), and once I did that, it
> became more obvious that aer_hest_parse() and aer_hest_parse_aff() are
> essentially similar, so I wonder if it's worth consolidating them, as
> below. It doesn't reduce the number of lines of code, but maybe it's
> simpler for the reader?


Hi Bjorn,

That is a nice cleanup. I tested it on my firmware first system.

Also, I double checked back through the ACPI spec, and there are
FIRMWARE_FIRST flags in the IA-32 Architecture Machine Check Exception
and IA-32 Architecture Corrected Machine Check error sources too. These
functions we are changing are specifically looking just for the AER
error sources. That is correct because AER firmware first is separate
from MCE/CMC firmware first. So, this patch looks good.

-Betty



\
 
 \ /
  Last update: 2013-12-16 17:21    [W:0.165 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site