Messages in this thread | | | Date | Mon, 16 Dec 2013 07:46:47 -0600 | Subject | Re: [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb | From | Rob Herring <> |
| |
On Sat, Dec 14, 2013 at 9:35 PM, <dt.tangr@gmail.com> wrote: > From: Daniel Tang <dt.tangr@gmail.com> > > > Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
A few minor things below. Otherwise:
Acked-by: Rob Herring <rob.herring@calxeda.com>
> --- > .../devicetree/bindings/usb/ci-hdrc-zevio.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt > new file mode 100644 > index 0000000..1a005eb > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-zevio.txt > @@ -0,0 +1,17 @@ > +* LSI Zevio USB OTG Controller > + > +Required properties: > +- compatible: Should be "lsi,zevio-usb" > +- reg: Should contain registers location and length > +- interrupts: Should contain controller interrupt > + > +Recommended properies:
To be consistent, should be "optional" rather than recommended.
s/properies/properties/
> +- vbus-supply: regulator for vbus > + > +Examples: > + usb0: usb@B0000000 { > + reg = <0xB0000000 0x1000>;
lower case hex is preferred.
> + compatible = "lsi,zevio-usb"; > + interrupts = <8>; > + vbus-supply = <&vbus_reg>; > + }; > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |