lkml.org 
[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] drivers: ata: Mark the function as static in libahci.c
On Sat, Dec 14, 2013 at 07:40:21PM +0530, Rashika Kheria wrote:
> This patch marks the function ahci_port_intr() and
> ahci_hw_port_interrupt() as static in libahci.c because they are not
> used outside this file.
>
> Thus, it also eliminates the following warnings in libahci.c:
> drivers/ata/libahci.c:1767:6: warning: no previous prototype for ‘ahci_port_intr’ [-Wmissing-prototypes]
> drivers/ata/libahci.c:1800:6: warning: no previous prototype for ‘ahci_hw_port_interrupt’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> drivers/ata/libahci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index c482f8c..36605ab 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -1764,7 +1764,7 @@ static void ahci_handle_port_interrupt(struct ata_port *ap,
> }
> }
>
> -void ahci_port_intr(struct ata_port *ap)
> +static void ahci_port_intr(struct ata_port *ap)
> {
> void __iomem *port_mmio = ahci_port_base(ap);
> u32 status;
> @@ -1797,7 +1797,7 @@ irqreturn_t ahci_thread_fn(int irq, void *dev_instance)
> }
> EXPORT_SYMBOL_GPL(ahci_thread_fn);
>
> -void ahci_hw_port_interrupt(struct ata_port *ap)
> +static void ahci_hw_port_interrupt(struct ata_port *ap)
> {
> void __iomem *port_mmio = ahci_port_base(ap);
> struct ahci_port_priv *pp = ap->private_data;
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-12-14 22:21    [W:3.633 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site