lkml.org 
[lkml]   [2013]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 001/115] gpu: ion: Add ION Memory Manager
    On Fri, Dec 13, 2013 at 05:18:00PM -0800, John Stultz wrote:
    > 0117-ion-Reenable-the-build.patch - This can be applied to the end of
    > the series, or folded into the last patch "ion: Update system heap
    > shrinker to use the new count/scan interface"

    Was there a 0116 patch somewhere?

    Everything works fine until this one (i.e. the driver doesn't build),
    but after applying this patch, the build breaks with a ton of undefined
    symbols at link time, here's a sample of some of them:

    ERROR: "ion_carveout_heap_destroy" [drivers/staging/android/ion/ion_heap.ko] undefined!
    ERROR: "ion_chunk_heap_destroy" [drivers/staging/android/ion/ion_heap.ko] undefined!
    ERROR: "ion_system_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
    ERROR: "ion_carveout_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
    ERROR: "ion_system_contig_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
    ERROR: "ion_cma_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
    ERROR: "ion_chunk_heap_create" [drivers/staging/android/ion/ion_heap.ko] undefined!
    ERROR: "ion_buffer_destroy" [drivers/staging/android/ion/ion_heap.ko] undefined!
    ERROR: "ion_heap_map_user" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
    ERROR: "ion_heap_unmap_kernel" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
    ERROR: "ion_heap_map_kernel" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
    ERROR: "ion_heap_pages_zero" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
    ERROR: "ion_pages_sync_for_device" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
    ERROR: "ion_buffer_cached" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!
    ERROR: "ion_heap_buffer_zero" [drivers/staging/android/ion/ion_chunk_heap.ko] undefined!

    So I'm not going to apply this patch, but I have the 115 previous
    patches (I took your modified 001 patch that you sent off-list to me.)

    Care to fix up the symbol issues in a new series of patches and then
    enabling the driver to build?

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2013-12-14 21:01    [W:3.680 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site