Messages in this thread | | | Date | Fri, 13 Dec 2013 00:57:35 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH 4/5] drivers: misc: Mark functions as static in ad525x_dpot.c |
| |
On Fri, Dec 13, 2013 at 12:27:10PM +0530, Rashika Kheria wrote: > This patch marks the function ad_dpot_add_files() and > ad_dpot_remove_files() as static in ad525x_dpot.c because they are not > used outside this file. > > Thus, it also eliminates the following warnings in ad525x_dpot.c: > drivers/misc/ad525x_dpot.c:644:5: warning: no previous prototype for ‘ad_dpot_add_files’ [-Wmissing-prototypes] > drivers/misc/ad525x_dpot.c:669:13: warning: no previous prototype for ‘ad_dpot_remove_files’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/misc/ad525x_dpot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c > index 0daadcf..d3eee11 100644 > --- a/drivers/misc/ad525x_dpot.c > +++ b/drivers/misc/ad525x_dpot.c > @@ -641,7 +641,7 @@ static const struct attribute_group ad525x_group_commands = { > .attrs = ad525x_attributes_commands, > }; > > -int ad_dpot_add_files(struct device *dev, > +static int ad_dpot_add_files(struct device *dev, > unsigned features, unsigned rdac) > { > int err = sysfs_create_file(&dev->kobj, > @@ -666,7 +666,7 @@ int ad_dpot_add_files(struct device *dev, > return err; > } > > -inline void ad_dpot_remove_files(struct device *dev, > +static inline void ad_dpot_remove_files(struct device *dev, > unsigned features, unsigned rdac) > { > sysfs_remove_file(&dev->kobj, > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |