Messages in this thread Patch in this message | | | Date | Fri, 13 Dec 2013 16:29:12 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH v3 07/23] mm/memblock: switch to use NUMA_NO_NODE instead of MAX_NUMNODES |
| |
On Mon, Dec 09, 2013 at 04:50:40PM -0500, Santosh Shilimkar wrote: > + if (nid == MAX_NUMNODES) > + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n", > + __func__);
Why not just use WARN_ONCE()? We'd want to know who the caller is anyway. Also, wouldn't something like the following simpler?
if (WARN_ONCE(nid == MAX_NUMNODES, blah blah)) nid = NUMA_NO_NODE;
> @@ -768,6 +773,11 @@ void __init_memblock __next_free_mem_range_rev(u64 *idx, int nid, > struct memblock_type *rsv = &memblock.reserved; > int mi = *idx & 0xffffffff; > int ri = *idx >> 32; > + bool check_node = (nid != NUMA_NO_NODE) && (nid != MAX_NUMNODES); > + > + if (nid == MAX_NUMNODES) > + pr_warn_once("%s: Usage of MAX_NUMNODES is depricated. Use NUMA_NO_NODE instead\n", > + __func__);
Ditto.
Provided the patch is tested on an actual NUMA setup.
Reviwed-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |