Messages in this thread | | | Date | Fri, 13 Dec 2013 11:14:37 -0600 | Subject | Re: [PATCH 3/5] drivers: misc: Mark functions as static in xpc_main.c | From | Robin Holt <> |
| |
On Fri, Dec 13, 2013 at 2:57 AM, Josh Triplett <josh@joshtriplett.org> wrote: > On Fri, Dec 13, 2013 at 12:24:05PM +0530, Rashika Kheria wrote: >> This patch marks the function xpc_init() and xpc_exit() as static in >> sgi-xp/xpc_main.c because they are not used outside this file. >> >> Thus, it also eliminates the following warnings in sgi-xp/xpc_main.c: >> drivers/misc/sgi-xp/xpc_main.c:1231:1: warning: no previous prototype for ‘xpc_init’ [-Wmissing-prototypes] >> drivers/misc/sgi-xp/xpc_main.c:1349:1: warning: no previous prototype for ‘xpc_exit’ [-Wmissing-prototypes] >> >> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org> Acked-by: Robin Holt <robinmholt@gmail.com>
> >> drivers/misc/sgi-xp/xpc_main.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c >> index 82dc574..5b1b10d 100644 >> --- a/drivers/misc/sgi-xp/xpc_main.c >> +++ b/drivers/misc/sgi-xp/xpc_main.c >> @@ -1227,7 +1227,7 @@ xpc_system_die(struct notifier_block *nb, unsigned long event, void *_die_args) >> return NOTIFY_DONE; >> } >> >> -int __init >> +static int __init >> xpc_init(void) >> { >> int ret; >> @@ -1345,7 +1345,7 @@ out_1: >> >> module_init(xpc_init); >> >> -void __exit >> +static void __exit >> xpc_exit(void) >> { >> xpc_do_exit(xpUnloading); >> -- >> 1.7.9.5 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |