lkml.org 
[lkml]   [2013]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 07/15] sched, thermal: Clean up preempt_enable_no_resched() abuse
    The only valid use of preempt_enable_no_resched() is if the very next
    line is schedule() or if we know preemption cannot actually be enabled
    by that statement due to known more preempt_count 'refs'.

    Cc: rjw@rjwysocki.net
    Cc: Eliezer Tamir <eliezer.tamir@linux.intel.com>
    Cc: rui.zhang@intel.com
    Cc: jacob.jun.pan@linux.intel.com
    Cc: Mike Galbraith <bitbucket@online.de>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: hpa@zytor.com
    Cc: Arjan van de Ven <arjan@linux.intel.com>
    Cc: lenb@kernel.org
    Signed-off-by: Peter Zijlstra <peterz@infradead.org>
    ---
    drivers/thermal/intel_powerclamp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/thermal/intel_powerclamp.c
    +++ b/drivers/thermal/intel_powerclamp.c
    @@ -443,7 +443,7 @@ static int clamp_thread(void *arg)
    atomic_inc(&idle_wakeup_counter);
    }
    tick_nohz_idle_exit();
    - preempt_enable_no_resched();
    + preempt_enable();
    }
    del_timer_sync(&wakeup_timer);
    clear_bit(cpunr, cpu_clamping_mask);



    \
     
     \ /
      Last update: 2013-12-12 15:41    [W:2.955 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site