lkml.org 
[lkml]   [2013]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next 0/3] seq_printf/puts/putc: Start to convert to return void
From
From: Joe Perches <joe@perches.com>
Date: Tue, 10 Dec 2013 21:12:41 -0800

> Many uses of the return value of seq_printf/seq_puts/seq_putc are
> incorrect. Many assume that the return value is the number of
> chars emitted into a buffer like printf/puts/putc.
>
> It would be better to make the return value of these functions void
> to avoid these misuses.
>
> Start to do so.
> Convert seq_overflow to a public function from a static function.
>
> Remove the return uses of seq_printf/seq_puts/seq_putc from net.
> Add a seq_overflow function call instead.

I'm fine with this going in whatever tree is appropriate for
the seq_overflow un-static change:

Acked-by: David S. Miller <davem@davemloft.net>


\
 
 \ /
  Last update: 2013-12-11 07:01    [W:0.094 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site