lkml.org 
[lkml]   [2013]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 02/14] efi: use early_memremap and early_memunmap
    On 12/11/13 at 10:39am, Matt Fleming wrote:
    > (Cc'ing Leif and Mark for the ARM-side of things)
    >
    > On Mon, 09 Dec, at 05:42:15PM, Dave Young wrote:
    > > In arch/x86/platform/efi/efi.c and drivers/firmware/efi/efi.c turn to use
    > > early_memremap/early_memunmap instead of early_ioremap/early_iounmap so sparse
    > > will be happy.
    > >
    > > Signed-off-by: Dave Young <dyoung@redhat.com>
    > > ---
    > > arch/x86/platform/efi/efi.c | 20 ++++++++++----------
    > > drivers/firmware/efi/efi.c | 4 ++--
    > > 2 files changed, 12 insertions(+), 12 deletions(-)
    >
    > This looks like a rather nice cleanup but the commit log could use a
    > little bit of tweaking...
    >
    > - Please start your commit title (the part after the subsystem tag)
    > with a capital letter, e.g.
    >
    > efi: Use early_memremap...
    >
    > - You need to explain in the commit title that you're fixing a sparse
    > warning. Anyone reading the patch subject will have no idea _why_
    > you're using early_memremap() and early_memunmap().
    >
    > - In the commit message body explain why sparse is currently unhappy.

    Sure, will do.

    --
    Thanks for review
    Dave


    \
     
     \ /
      Last update: 2013-12-12 03:21    [W:4.167 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site