Messages in this thread | | | Date | Thu, 12 Dec 2013 09:07:14 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH v2 7/7] mm/migrate: remove result argument on page allocation function for migration |
| |
On Wed, Dec 11, 2013 at 04:00:56PM +0000, Christoph Lameter wrote: > On Wed, 11 Dec 2013, Joonsoo Kim wrote: > > > In do_move_pages(), if error occurs, 'goto out_pm' is executed and the > > page status doesn't back to userspace. So we don't need to store err number. > > If a page cannot be moved then the error code is containing the number of > pages that could not be migrated. The check there is for err < 0. > So a positive number is not an error. > > migrate_pages only returns an error code if we are running out of memory.
Ah... I missed it. I will drop this patch and send v3 for whole patchset.
Thanks.
| |