lkml.org 
[lkml]   [2013]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 8/8] sched/numa: drop unnecessary variable in task_weight
On Wed, Dec 11, 2013 at 09:21:23AM +0000, Mel Gorman wrote:
> On Wed, Dec 11, 2013 at 08:50:01AM +0800, Wanpeng Li wrote:
> > Drop unnecessary total_faults variable in function task_weight to unify
> > task_weight and group_weight.
> >
> > Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>
> Nak.
>
> task_weight is called for tasks other than current. If p handles a fault
> in parallel then it can drop to 0 between when it's checked and used to
> divide resulting in an oops.

So we have the same race on group_weight(), and we have to add a local
variable to store p->numa_group->total_faults?

Thanks,
Naoya Horiguchi


\
 
 \ /
  Last update: 2013-12-11 16:01    [W:0.134 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site