Messages in this thread | | | Date | Tue, 10 Dec 2013 21:05:29 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware |
| |
Hi,
On Mon, Dec 09, 2013 at 10:43:29AM +0800, Chen-Yu Tsai wrote: > >> @@ -2759,15 +2760,18 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device, > >> } > >> } > >> > >> + clk_disable_unprepare(priv->stmmac_clk); > >> + > > > > Hu? Why do you disable the clock? don't you need it afterwards? > > The clock is enabled in *_open (when the network interface is used), > and disabled in *_close.
Maybe it is the real issue then.
Why don't you move the clk_disable to _remove then?
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |